fix: Enable cast string to int tests and fix compatibility issue #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
May 20, 2024
| @@ -82,7 +82,7 @@ macro_rules! cast_utf8_to_int { | |||
| for i in 0..len { | |||
| if $array.is_null(i) { | |||
| cast_array.append_null() | |||
| } else if let Some(cast_value) = $cast_method($array.value(i).trim(), $eval_mode)? { | |||
There was a problem hiding this comment.
We originally trimmed the input strings here, so error messages did not have access to the original inputs
andygrove
commented
May 20, 2024
|
|
||
| if state == State::ParseSignAndDigits { | ||
| if !parsed_sign { | ||
| for (i, ch) in trimmed_str.char_indices() { |
There was a problem hiding this comment.
We process the trimmed string here and we no longer need the logic for skipping leading and trailing whitespace
andygrove
commented
May 20, 2024
| @@ -1070,7 +1050,7 @@ fn do_cast_string_to_int< | |||
| if ch == '.' { | |||
| if eval_mode == EvalMode::Legacy { | |||
| // truncate decimal in legacy mode | |||
| state = State::ParseFractionalDigits; | |||
| parse_sign_and_digits = false; | |||
| continue; | |||
| } else { | |||
| return none_or_err(eval_mode, type_name, str); | |||
There was a problem hiding this comment.
error messages refer to the original input string, not the trimmed version
kazuyukitanimura
approved these changes
May 20, 2024
viirya
approved these changes
May 20, 2024
|
So do you thing the perf improvement is because we are no longer trimming? |
We are still trimming, but we are no longer performing the redundant conditional logic in the main loop to skip leading and trailing whitespace. |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #431
Rationale for this change
Enable cast string to int as a compatible expression.
Also, there is a performance improvement with these changes:
What changes are included in this PR?
How are these changes tested?
Enabled the tests that were previously disabled